*: Catch up with refs/ removal (remove RefsRegexp, etc.) #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The restriction on names was removed by 0556a6b (image-layout: ./refs/ -> index.json, 2017-01-26, opencontainers#533) and the replacement (org.opencontainers.ref.name) has no equivalent limitation. Signed-off-by: W. Trevor King <[email protected]>
wking
force-pushed
the
no-refs-catchup
branch
from
0dd8971 to
9b434a7
Compare
mikebrow
reviewed
Feb 8, 2017
image-layout.md
Outdated
| @@ -58,7 +58,7 @@ A blob, referenced with digest `<alg>:<hex>` (per [descriptor](descriptor.md#dig | |||
| The character set of the entry name for `<hex>` and `<alg>` MUST match the respective grammar elements described in [descriptor](descriptor.md#digests-and-verification). | |||
| For example `sha256:5b` will map to the layout `blobs/sha256/5b`. | |||
|
|
|||
| The blobs directory MAY contain blobs which are not referenced by any of the refs. | |||
| The blobs directory MAY contain blobs which are not referenced by any of the [refs](indexjson-file). | |||
There was a problem hiding this comment.
"indexjson-file?"
Ah I think you wanted "image-layout.md#indexjson-file" or is this a placeholder for another file link yet to come?
wking
force-pushed
the
no-refs-catchup
branch
from
9b434a7 to
de2f01d
Compare
To make it clear what they are now that we have no "Refs" section (which was removed in 0556a6b, image-layout: ./refs/ -> index.json, 2017-01-26, opencontainers#533). Signed-off-by: W. Trevor King <[email protected]>
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor fixups in the wake of #533. Details in the commit messages (which I'm happy to split out into separate PRs if folks want).