Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs-go/v1/config.go: Capitalize Labels #630

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

erikh
Copy link
Contributor

@erikh erikh commented Mar 31, 2017

This field was not similar to the other fields and causes problems when dealing with using this struct to convert between docker v1 and oci v1 repositories (I cheat a little by doing this, I realize it's not a long term solution).

Still, this seems out of place and I wanted to fix it while I noticed.

@erikh
Copy link
Contributor Author

erikh commented Mar 31, 2017

gah stupid github edit

@erikh erikh changed the title v1/config.go: Capitalize Labels specs-go/v1/config.go: Capitalize Labels Mar 31, 2017
@jonboulle
Copy link
Contributor

jonboulle commented Mar 31, 2017

LGTM, nice catch!

Approved with PullApprove

@stevvooe
Copy link
Contributor

stevvooe commented Mar 31, 2017

LGTM

Approved with PullApprove

@stevvooe stevvooe merged commit 76af9f5 into opencontainers:master Mar 31, 2017
@vbatts vbatts mentioned this pull request May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants