Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specs-go: add const for annotation keys #689

Merged
merged 1 commit into from
May 31, 2017
Merged

specs-go: add const for annotation keys #689

merged 1 commit into from
May 31, 2017

Conversation

AkihiroSuda
Copy link
Member

Signed-off-by: Akihiro Suda [email protected]

@AkihiroSuda AkihiroSuda mentioned this pull request May 26, 2017
Merged
@vbatts
Copy link
Member

vbatts commented May 26, 2017

oh interesting. We had not done this yet. But why for only ref.name? there are others in annotations.md

@AkihiroSuda
Copy link
Member Author

Added them.
Please review carefully so as to make sure I didn't make any typo 😄

@AkihiroSuda AkihiroSuda changed the title specs-go: add const for org.opencontainers.image.ref.name specs-go: add const for annotation keys May 27, 2017
@vbatts
Copy link
Member

vbatts commented May 30, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

1 similar comment
@stevvooe
Copy link
Contributor

stevvooe commented May 30, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@vbatts vbatts merged commit 47238a2 into opencontainers:master May 31, 2017
@vbatts vbatts mentioned this pull request Jul 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkihiroSuda @vbatts @stevvooe