Remove pipe close before exec.

Pipe close before exec is not necessary as os.Pipe() is calling pipe2 with O_CLOEXEC option. Signed-off-by: Marco Vedovati <[email protected]> Co-authored-by: Georgi Sabev <[email protected]>
opencontainers · Apr 4, 2019 · e4ca720 · e4ca720
1 parent 8e8a907
commit e4ca720
Showing 1 changed file with 0 additions and 5 deletions.
diff --git a/libcontainer/standard_init_linux.go b/libcontainer/standard_init_linux.go
@@ -16,7 +16,6 @@ import (
 	"github.com/opencontainers/runc/libcontainer/system"
 	"github.com/opencontainers/selinux/go-selinux/label"
 	"github.com/pkg/errors"
-	"github.com/sirupsen/logrus"
 
 	"golang.org/x/sys/unix"
 )
@@ -208,10 +207,6 @@ func (l *linuxStandardInit) Init() error {
 			return newSystemErrorWithCause(err, "init seccomp")
 		}
 	}
-
-	logPipe, _ := (logrus.StandardLogger().Out).(*(os.File))
-	logPipe.Close()
-
 	if err := syscall.Exec(name, l.config.Args[0:], os.Environ()); err != nil {
 		return newSystemErrorWithCause(err, "exec user process")
 	}