Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: DESTDIR is not added to PREFIX if PREFIX is manually given #2571

Closed
nanonyme opened this issue Aug 30, 2020 · 1 comment · Fixed by #2578
Closed

Makefile: DESTDIR is not added to PREFIX if PREFIX is manually given #2571

nanonyme opened this issue Aug 30, 2020 · 1 comment · Fixed by #2578
Milestone

Comments

@nanonyme
Copy link

When used with packaging, we might want prefix to point to /usr and collect package artifacts into /staging-dir. In this case we would set PREFIX=/usr and DESTDIR=/staging-dir. This results in make actually installing files under /usr (which might not be mutable) instead of under /staging-dir/usr.

@kolyshkin
Copy link
Contributor

Thanks for reporting, proposed fix is #2578

@kolyshkin kolyshkin added this to the 1.0.0-rc93 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants