-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: fix DESTDIR handling #2578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm, I haven't seen this failure before :(
and now it's consistently failing everywhere 🤔 |
OK the expected output is
while the actual is
Fix is coming |
|
DESTDIR should only be used while installing. To test: make DESTDIR=$(pwd)/inst PREFIX=/usr install install-man install-bash Before this commit, this would result in installing to /usr rather than $(pwd)/usr. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
fix-destdir
branch
from
September 9, 2020 16:23
471e5ff
to
8297ae4
Compare
rebased on top of current master (merged #2580 should fix CI) |
Misread. Looks good to me. |
mrunalp
approved these changes
Sep 10, 2020
@AkihiroSuda PTAL |
1 similar comment
@AkihiroSuda PTAL |
AkihiroSuda
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESTDIR should only be used while installing.
To test:
Before this commit, this would result in installing to
/usr
rather than
$(pwd)/usr
.Fixes: #2571