Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add godoc links to README.md files #1284

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Add godoc links to README.md files #1284

merged 1 commit into from
Jan 30, 2017

Conversation

stevenh
Copy link
Contributor

@stevenh stevenh commented Jan 21, 2017

Add godoc links to README.md files for runc and libcontainer so its easy to access the golang documentation.

@stevenh
Add godoc links to README.md files
a887fc3 
Add godoc links to README.md files for runc and libcontainer so its easy to access the golang documentation.

Signed-off-by: Steven Hartland <[email protected]>
@stevenh
Copy link
Contributor Author

stevenh commented Jan 22, 2017

Pretty sure the jenkins failure cant have been caused by these changes.

@cyphar
Copy link
Member

cyphar commented Jan 24, 2017

No, the Jenkins failure is because of another bug we have at the moment (#1236).

@hqhq
Copy link
Contributor

hqhq commented Jan 27, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@caniszczyk
Copy link
Contributor

looks like janky is failing but Travis CI is not cc: @crosbymichael

@cyphar
Copy link
Member

cyphar commented Jan 27, 2017 •
edited
Loading

@caniszczyk You don't need to CC him -- anyone in the #docker-maintainers channel (which is public) on freenode can say !rebuild runc#<pr> to restart a Janky run. I've just kicked it off again.

@caniszczyk
Copy link
Contributor

@cyphar thanks TIL, I had no idea!

@cyphar
Copy link
Member

cyphar commented Jan 27, 2017

Oh, actually only voiced people in the channel can talk. So really only myself and Michael can kick off jobs (plus a few others from the Docker community).

@stevenh
Copy link
Contributor Author

stevenh commented Jan 27, 2017

Still failing due to #1236 :(

@cyphar
Copy link
Member

cyphar commented Jan 27, 2017 •
edited
Loading

I can kick of the job until it succeeds. We can also just LGTM and merge it without Janky passing because it wasn't a code change. No need to be worried.

@cyphar
Copy link
Member

cyphar commented Jan 27, 2017 •
edited by caniszczyk
Loading

LGTM.

Approved with PullApprove

@mrunalp
Copy link
Contributor

mrunalp commented Jan 30, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 510879e into opencontainers:master Jan 30, 2017
@stevenh stevenh deleted the godoc branch February 1, 2017 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevenh @cyphar @hqhq @caniszczyk @mrunalp