libcontainer: Don't set container state to running when exec'ing #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to set the container state to "running" as a temporary value when exec'ing a process on a container in "created" state. The problem doing this is that consumers of the libcontainer library might use it by keeping pointers in memory. In this case, the container state will indicate that the container is running, which is wrong, and this will end up with a failure on the next action because the check for the container state transition will complain. Fixes opencontainers#1767 Signed-off-by: Sebastien Boeuf <[email protected]>
|
@mrunalp is there any test I can run to make sure this does not break some expected behavior ? |
|
I'll run this patch on the containerd stress test server and see if we have any issues. |
|
Thank you @crosbymichael ! |
|
I'll let it run all weekend and let you know. so far so good as far as identifying any regressions on the |
|
@crosbymichael that's great, I really don't want to break anything and such testing seems very appropriate to confirm if we can merge this. |
|
Looks fine 👍 will wait for the test results :) |
|
@crosbymichael any results ? |
|
No issues |
|
LGTM |
|
Cool :) |
|
@mrunalp PTAL |
|
LGTM |
This was referenced Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to set the container state to "running" as a
temporary value when exec'ing a process on a container in "created"
state. The problem doing this is that consumers of the libcontainer
library might use it by keeping pointers in memory. In this case,
the container state will indicate that the container is running, which
is wrong, and this will end up with a failure on the next action
because the check for the container state transition will complain.
Fixes #1767
Signed-off-by: Sebastien Boeuf [email protected]