Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errcheck linting fixes #2781

Merged
merged 7 commits into from
May 25, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
errcheck: signals
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah committed May 20, 2021

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming
commit 0c65f833ef5efd4145d6af8ec6355772bf1f64e9
8 changes: 4 additions & 4 deletions signals.go
Original file line number Diff line number Diff line change
@@ -66,11 +66,11 @@ func (h *signalHandler) forward(process *libcontainer.Process, tty *tty, detach

if h.notifySocket != nil {
if detach {
h.notifySocket.run(pid1)
_ = h.notifySocket.run(pid1)
return 0, nil
}
h.notifySocket.run(os.Getpid())
go h.notifySocket.run(0)
_ = h.notifySocket.run(os.Getpid())
go func() { _ = h.notifySocket.run(0) }()
}

// Perform the initial tty resize. Always ignore errors resizing because
@@ -96,7 +96,7 @@ func (h *signalHandler) forward(process *libcontainer.Process, tty *tty, detach
// call Wait() on the process even though we already have the exit
// status because we must ensure that any of the go specific process
// fun such as flushing pipes are complete before we return.
process.Wait()
_, _ = process.Wait()
return e.status, nil
}
}