libct: Don't use stale mount fds #3518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mountConfig fd field can be set by a previous iteration and we are not clearing it. Let's just move the mountConfig inside the loop, so we avoid all this kinds of bugs in the future too. Note that none of the fields set on mountConfig have secondary effects (they are just reading fields from config/iConfig), so this is safe to do. Signed-off-by: Rodrigo Campos <[email protected]>
|
cc @kolyshkin |
rata
force-pushed
the
rata/stale-mount-fds
branch
from
ba63cae to
9bba111
Compare
|
I've also verified that the test passes with the fix and fails without (see the revert commit that I removed now) |
This was created by kolyshkin in: opencontainers#3510 Signed-off-by: Rodrigo Campos <[email protected]>
rata
force-pushed
the
rata/stale-mount-fds
branch
from
9bba111 to
7c5e68c
Compare
|
I think that #3512 is a better way long term |
|
Sure, closing then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for the same bug that PR #3510 is tackling. Both PRs should have the same effect (the .fd field is nil when it should).
I'm just opening this PR so people can chose the PR they prefer. Both are correct and easy to backport.
What I like about this is that similar bugs should not happen, as the mountConfig is cleared on every iteration, and should be very simple to backport too.
Please keep me in the loop in the future too, so I can help to fix the bugs that come around :)