Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: replace local hello world bundle with busybox bundle #3526

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

zhsj
Copy link
Contributor

@zhsj zhsj commented Jul 4, 2022

Currently only amd64 and arm64v8 tarball have been checked in testdata,
while busybox bundle is downloaded on fly, and supports multiple architectures.

To enable integration tests for more architectures, the hello world
bundle is replaced by busybox one.

Signed-off-by: Shengjing Zhu [email protected]

Currently only amd64 and arm64v8 tarball have been checked in testdata,
while busybox bundle is downloaded on fly, and supports multiple architectures.

To enable integration tests for more architectures, the hello world
bundle is replaced by busybox one.

Signed-off-by: Shengjing Zhu <[email protected]>
@zhsj
Copy link
Contributor Author

zhsj commented Jul 4, 2022

I'm running integration tests for the runc Debian package. I finally make the tests pass on amd64 and arm64. Now I want to enable more architectures, which are armhf, armel, i386, ppc64el, s390x, riscv64.

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I guess we don't really benefit from the fact that hello image is smaller and doesn't have to be downloaded, because in most cases we still use busybox.

@kolyshkin kolyshkin merged commit 7928a0d into opencontainers:main Jul 11, 2022
@zhsj zhsj deleted the replace-hello-image branch July 12, 2022 00:33
@rata rata mentioned this pull request Feb 6, 2023
@kolyshkin kolyshkin mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants