Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.codespellrc: update for 2.2.5 #3907

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

kolyshkin
Copy link
Contributor

Remove some old exceptions (no longer needed), add a new one
(codespell 2.2.5 flags "(mis)features" in docs/terminal.md).

This fixes the CI

Remove some old exceptions (no longer needed), add a new one
(codespell 2.2.5 flags "(mis)features" in docs/terminal.md).

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin added easy-to-review area/ci backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Jun 16, 2023
@kolyshkin kolyshkin marked this pull request as ready for review June 16, 2023 17:16
@cyphar cyphar merged commit e099ffb into opencontainers:main Jun 21, 2023
@kolyshkin kolyshkin added backport/1.1-done A PR in main branch which has been backported to release-1.1 and removed backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Jun 21, 2023
@cyphar
Copy link
Member

cyphar commented Jun 22, 2023

FWIW, I think we should have the GHA only do a codespell scan of changed files when triggered from a PR (or even better, only the chunks that were touched by the PR -- but I suspect codespell doesn't support that).

@kolyshkin
Copy link
Contributor Author

The fix (against a new codespell version suddenly breaking our CI) would be to pin codespell version, but since I doubt they make frequent releases, I think we're fine doing something like this PR from time to time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci backport/1.1-done A PR in main branch which has been backported to release-1.1 easy-to-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants