Revert "libct/validator: Error out on non-abs paths" #3971
Merged
+33
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rata
force-pushed
the
rata/abs-dest-path-warn
branch
2 times, most recently
from
0c196d0 to
d814374
Compare
This reverts commit 881e92a and adjust the code so the idmap validations are strict. We now only throw a warning and the container is started just fine. Signed-off-by: Rodrigo Campos <[email protected]>
The idea was to make them strict on dest path from the beginning for idmap mounts, as runc would do that for all mounts in the future. But that is causing too many problems. For now, let's just allow relative paths for idmap mounts too. It just seems safer. Signed-off-by: Rodrigo Campos <[email protected]>
rata
force-pushed
the
rata/abs-dest-path-warn
branch
from
d814374 to
ec2ffae
Compare
|
cc @thaJeztah |
AkihiroSuda
approved these changes
Aug 8, 2023
lifubang
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here it seems safer, at least for now, to revert the error and continue to throw a warning.
This reverts commit 881e92a and adjust the code so the idmap validations are strict.
Fixes: #3944
Updates: #3020 (There is no way to re-open it automatically, can someone re-open it?)