Add type alias for ContainerState for compatibility #1063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure the original purpose of this breaking change.
Others still can assign State.Status with `ContainerState("whatever")`.
Actually Go doesn't have a proper Enum type.
Signed-off-by: Shengjing Zhu <[email protected]>
thaJeztah
approved these changes
Sep 10, 2020
|
ping @kolyshkin @cyphar @mrunalp PTAL |
|
Any chance to get this merged before 1.0.3? (Will there be a 1.0.3?) |
|
@zhsj any reason you closed this? |
As time goes by , I have fixed the breaks in other packages, Edit: It's been so long that I forget which packages I have fixed. |
|
There might still be other consumers, for which it could make sense to add it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure the original purpose of this breaking change.
Others still can assign State.Status with
ContainerState("whatever").Actually Go doesn't have a proper Enum type.
So I propose we keep the compatibility with less effort.