Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-config-linux.md: fix the type of cpus and mems #252

Merged
merged 1 commit into from
Nov 18, 2015

Conversation

laijs
Copy link
Contributor

@laijs laijs commented Nov 17, 2015

Signed-off-by: Lai Jiangshan [email protected]

@hqhq
Copy link
Contributor

hqhq commented Nov 17, 2015

Although it's likely we'll change all cgroup settings to points in favor of #233 , it's definitely a bug in spec for now if I didn't miss anything, I'm OK we let it in first, so LGTM.

@wking
Copy link
Contributor

wking commented Nov 17, 2015

On Tue, Nov 17, 2015 at 06:26:28AM -0800, Qiang Huang wrote:

Although it's likely we'll change all cgroup settings to points in
favor of #233 , it's definitely a bug in spec for now if I didn't
miss anything, I'm OK we let it in first, so LGTM.

+1 to all that ;).

@mrunalp
Copy link
Contributor

mrunalp commented Nov 18, 2015

LGTM

mrunalp pushed a commit that referenced this pull request Nov 18, 2015
runtime-config-linux.md: fix the type of cpus and mems
@mrunalp mrunalp merged commit 169b3d8 into opencontainers:master Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants