config-linux: Update links to cgroups documentation #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * **`path`** *(string, required)* - full path to device inside container. | ||
| * **`major, minor`** *(int64, required)* - [major, minor numbers][devices] for the device. | ||
| * **`fileMode`** *(uint32, required)* - file mode for the device. | ||
| You can also control access to devices [with cgroups](#device-whitelist). |
There was a problem hiding this comment.
Are all the fields required?
There was a problem hiding this comment.
On Wed, Jan 27, 2016 at 12:44:58PM -0800, Vish Kannan wrote:
- You can also control access to devices with cgroups.
Are all the fields required?
The change's you are commenting on are part of #298 1. If you want
to review this PR before #298 lands, you probably just want to look at
the tip commit 2.
wking
force-pushed
the
cgroup-v1-links
branch
from
a722d32 to
01e5ed1
Compare
wking
force-pushed
the
cgroup-v1-links
branch
from
01e5ed1 to
22e2e3b
Compare
With 34a9304a (Merge branch 'for-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup, 2016-01-13, [1]), Linux restructured their cgroups documentation. This updated all of our Documentation/cgroups references to match the new layout, using reference-style links [2] which let us collect link label definitions at the bottom of the file. That makes the spec source easier to read (no distracting URLs in the middle of a sentence) and makes the URLs easier to update (only one place to check / fix). [1]: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=34a9304a96d6351c2d35dcdc9293258378fc0bd8 [2]: http://daringfireball.net/projects/markdown/syntax#link Signed-off-by: W. Trevor King <[email protected]>
wking
force-pushed
the
cgroup-v1-links
branch
from
22e2e3b to
1b0056c
Compare
|
LGTM |
1 similar comment
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Feb 4, 2016
config-linux: Update links to cgroups documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 34a9304a (Merge branch 'for-4.5' of
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup, 2016-01-13),
Linux restructured their cgroups documentation. This updated all of
our Documentation/cgroups references to match the new layout, using
reference-style links which let us collect link label definitions
at the bottom of the file. That makes the spec source easier to read
(no distracting URLs in the middle of a sentence) and makes the URLs
easier to update (only one place to check / fix).
This builds on #298, so that PR should land first.