*: specs -> runtime-spec #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Batts <[email protected]>
|
Everything through f6e82a9 looks good to me, although “Open Container
Runtime Specification” might be a more compact way to convey the same
idea.
|
|
bumped the wording just a little. PTAL. |
|
LGTM |
|
I like @wking suggestion of "Open Container Runtime Specification" as the title. |
And align wording with opencontainers/image-spec#5 Signed-off-by: Vincent Batts <[email protected]>
|
updated |
|
LGTM |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Aug 3, 2016
Catch up with the spec title from faad7e0 (README: title rename, 2016-04-04, opencontainers#365). Also make the Go comment consistent with the Markdown spec (no need to maintain two phrasings for the same idea). The only difference between the phrasings is now some shuffling at the beginning to start off with the property name (to keep godoc happy). The JSON Schema entry (in defs.json) is different too, because it has to apply to both the configuration and state JSON, so mentioning "bundle" makes less sense than mentioning "document". Signed-off-by: W. Trevor King <[email protected]>
Mashimiao
pushed a commit
to Mashimiao/specs
that referenced
this pull request
Aug 19, 2016
Catch up with the spec title from faad7e0 (README: title rename, 2016-04-04, opencontainers#365). Also make the Go comment consistent with the Markdown spec (no need to maintain two phrasings for the same idea). The only difference between the phrasings is now some shuffling at the beginning to start off with the property name (to keep godoc happy). The JSON Schema entry (in defs.json) is different too, because it has to apply to both the configuration and state JSON, so mentioning "bundle" makes less sense than mentioning "document". Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Batts [email protected]