specs-go/config: Make consoleSize a pointer #581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we it will never be omitted when empty. This is the same case as 6323157 (specs-go/config: Make Linux and Solaris omitempty (again), 2016-06-17, opencontainers#502). Signed-off-by: W. Trevor King <[email protected]>
|
Can we finish the discussion in other PRs until you start opening up more PRs to change other unrelated things? |
|
On Thu, Sep 22, 2016 at 09:14:50AM -0700, Michael Crosby wrote:
I'd rather file the issue, and you can tag it priority/P3 if you don't |
|
I'd forgotten about this one, but the change recently landed via #792. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we it will never be omitted when empty. This is the same case as 6323157 (specs-go/config: Make Linux and Solaris omitempty (again), 2016-06-17, #502).