config-linux: RFC 2119 MUST for absolute linux.namespaces[].path #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old language is from 72cbff6 (config-linux.md: clearly require absolute path for namespace, 2017-03-10, opencontainers#720), but without RFC 2119 language in the absolute path wording, it's not a compliance requirement (per spec.md's "compliant" definition). This commit adjusts the language to bring it in line with our current wording for maskedPaths and readonlyPaths, which we've had since 25f44dd ( config-linux: fix format and definitely require value of masked and readonly paths, 2016-09-30, opencontainers#587). Signed-off-by: W. Trevor King <[email protected]>
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old language is from 72cbff6 (#720), but without RFC 2119 language in the absolute path wording, it's not a compliance requirement (per
spec.md's “compliant” definition). This commit adjusts the language to bring it in line with our current wording formaskedPathsandreadonlyPaths, which we've had since 25f44dd (#587).This is technically a breaking change, because a config with a relative namespace path would have been compliant before, but will be non compliant with this PR. However, I think the previous “an absolute path to namespace file” wording is clear enough that config authors are unlikely to be relying on relative namespace paths in configs. If we are comfortable enough with that assumption (I am, but I'm not a maintainer), we can push this out as a patch-level change without fear of breaking config authors. If we aren't comfortable with that assumption, we'll want to queue this change up for 2.0.