validate: add validation for OOMScoreAdj #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The acceptable values range from -1000 to +1000. According to the description of "oom_score_adj" (https://www.kernel.org/doc/Documentation/filesystems/proc.txt) Signed-off-by: Zhai Zhaoxuan <[email protected]>
|
I think this also is not needed, because we plan to use schema check value type and limit. |
|
Ok,I found it in the schema. |
|
No, schema and validation focus on different aspects |
|
On Tue, Jan 24, 2017 at 07:57:04AM -0800, Ma Shimiao wrote:
No, schema and validation focus on different aspects
I don't think that's quite right, and would rather say JSON Schema
validation is a subset of full validation. See the still-in-flight
#197 for applying this approach.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acceptable values range from -1000 to +1000.
According to the description of "oom_score_adj" (https://www.kernel.org/doc/Documentation/filesystems/proc.txt)