Update rc6 #425
Update rc6 #425
Conversation
Signed-off-by: Ma Shimiao <[email protected]>
| // Process configures the container process. | ||
| Process Process `json:"process"` | ||
| Process *Process `json:"process,omitempty"` |
There was a problem hiding this comment.
I think this change will mean you'll need an initProcess function and some nil checks (e.g. here). You'll also need similar changes for Root → *Root.
| @@ -540,14 +550,21 @@ const ( | |||
| type LinuxSeccompArg struct { | |||
| Index uint `json:"index"` | |||
| Value uint64 `json:"value"` | |||
| ValueTwo uint64 `json:"valueTwo"` | |||
| ValueTwo uint64 `json:"valueTwo,omiempty"` | |||
There was a problem hiding this comment.
You'll probably want to use a runtime-spec commit that includes opencontainers/runtime-spec#884 (which didn't make it into rc6). We'll have to replace the version comparison and generation default with a hard-coded version, probably by defining our own target-spec-version variable in a local version package. But because runtime-spec versions do not cover their Go library, I think we'd have to do that regardless.
Signed-off-by: Ma Shimiao <[email protected]>
|
/ping @opencontainers/runtime-tools-maintainers? This is quite important for tools like |
|
LGTM |
1 similar comment
|
LGTM |
|
❤️ Thanks for the fast reponse. 😸 |
updated to spec v1.0.0-rc6 and fix changes based on it.