Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding namespace override #171

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

brito-rafa
Copy link
Contributor

Adding parameter namespaceOverride as requests on #161.

When using --set namespaceOverride=<namespace>, it is required to pre-create the namespace.

Improved the README as well.

Log of the test:

# create the namespace
% k create ns override

% helm install opencost-override ./charts/opencost --set namespaceOverride=override
NAME: opencost-override
LAST DEPLOYED: Thu Jan 11 14:49:52 2024
NAMESPACE: default  <-----------
STATUS: deployed
REVISION: 1
TEST SUITE: None

% helm install opencost-vanilla ./charts/opencost --namespace=vanilla --create-namespace 
NAME: opencost-vanilla
LAST DEPLOYED: Thu Jan 11 14:50:14 2024
NAMESPACE: vanilla
STATUS: deployed
REVISION: 1
TEST SUITE: None

% k get pod -n override -w
NAME                                 READY   STATUS    RESTARTS   AGE
opencost-override-844bd7498f-w5szq   1/2     Running   0          66s
opencost-override-844bd7498f-w5szq   2/2     Running   0          2m6s   <------ running

% k get pod -n vanilla    
NAME                                READY   STATUS    RESTARTS   AGE
opencost-vanilla-78cb5bfbc9-5jg4j   2/2     Running   0          2m3s

@mattray mattray force-pushed the 161-namespace-override branch from 52540e7 to ce6d051 Compare January 16, 2024 04:07
@mattray mattray merged commit 28e114a into opencost:main Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants