curvefs mds heartbeat doesn't delete copyset creating. #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
wu-hanqing
reviewed
Jan 18, 2022
curvefs/src/mds/topology/topology.h
Outdated
| @@ -445,6 +451,8 @@ class TopologyImpl : public Topology { | |||
|
|
|||
| std::string GetHostNameAndPortById(MetaServerIdType msId) override; | |||
|
|
|||
| bool IsCopysetCreating(const CopySetKey &key) override; | |||
There was a problem hiding this comment.
declare it as const member functions
There was a problem hiding this comment.
declare it as const member functions
fixed.
|
|
||
| bool TopologyImpl::IsCopysetCreating(const CopySetKey &key) { | ||
| ReadLockGuard rlockCopySetCreating(copySetCreatingMutex_); | ||
| return copySetCreating_.find(key) == copySetCreating_.end() ? false : true; |
There was a problem hiding this comment.
return copysetCreating_.find(key) != copysetCreating_.end();
// or
return coypsetCreating_.count(key) != 0;There was a problem hiding this comment.
return copysetCreating_.find(key) != copysetCreating_.end(); // or return coypsetCreating_.count(key) != 0;
fixed
SeanHai
force-pushed
the
delete_copyset
branch
from
2d87142 to
d59b80e
Compare
The empty conf will send to metaserver to delete copysets which don't exist in mds, but when the copyset just created in metaserver and have not add to topology, the metaserver heartbeat will contain these copysets' infomation.
SeanHai
force-pushed
the
delete_copyset
branch
from
d59b80e to
6348413
Compare
wu-hanqing
approved these changes
Jan 19, 2022
cw123
reviewed
Jan 19, 2022
| topology_->RemoveCopySetCreating(CopySetKey(poolId, id)); | ||
| } | ||
| } | ||
|
|
||
| TopoStatusCode TopologyManager::CreateCopyset() { |
There was a problem hiding this comment.
Does CreateCopyset have concurrency?
There was a problem hiding this comment.
Does CreateCopyset have concurrency?
Concurrency occurs in extreme cases, but the copysets' id must be different.
cw123
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curvefs mds heartbeat doesn't delete copyset creating.
The empty conf will send to metaserver to delete copysets which don't exist in mds, but when the copyset just created in metaserver and have not add to topology, the metaserver heartbeat will contain these copysets' infomation.
What problem does this PR solve?
Issue Number: close #xxx
#999
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List