[fix] older versions of the ss command do not have the --no-header option #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wine93
reviewed
Aug 20, 2023
jyf111
force-pushed
the
fix-ss-no-header
branch
from
b783f6f to
3052d8f
Compare
caoxianfei1
requested changes
Sep 12, 2023
jyf111
force-pushed
the
fix-ss-no-header
branch
2 times, most recently
from
96c3d76 to
d74b889
Compare
|
lgtm |
Wine93
reviewed
Sep 25, 2023
…tion solution: execute the ss command in a temporary container to precheck for ports in use instead Signed-off-by: jyf111 <[email protected]>
jyf111
force-pushed
the
fix-ss-no-header
branch
from
d74b889 to
60cfabf
Compare
caoxianfei1
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #226 and #214.
Solution: execute the
sscommand in a temporary container to precheck for ports in use instead.Side effects: the port precheck process will now take a bit longer, since we need to pull image, create a container, start the container, exec the
sscommand for each port, and then stop and remove the container.