Skip to content

Commit

Permalink
fix: Allow md files to have duplicate headings, as the duplication of…
Browse files Browse the repository at this point in the history
… headings test is not markdown hierarchy aware

Signed-off-by: Chris Butler <[email protected]>
  • Loading branch information
butler54 committed May 15, 2024
1 parent 1ccb219 commit 546e816
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 13 deletions.
7 changes: 1 addition & 6 deletions .github/linters/.markdown-lint.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
{
"default": true,
"MD003": false,
"MD013": false,
"MD033": false
}
{"default": true, "MD003": false, "MD013": false, "MD033": false, "MD036": false}
14 changes: 7 additions & 7 deletions docs/ADR/ADR_001.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,26 @@ The second question is to ensure that the data scientists don't need to directly

## Considered Options

### Depend exclusively on external object storage.
### Depend exclusively on external object storage

*Positives*
#### Positives

- No infastructure consumption for storage on cluster.
-

*Negatives*
#### Negatives

- Requires credential management and access to s3 in the cloud account with appropriate IAM credentials.
- S3 is not a given in on-premise environment

### Leverage object storage via an internal platform exclusively using minio

*Positives*
#### Positives

- Consistent addressing for object storage in cluster for application development
- Closed loop credential management easing automation

*Negatives*
#### Negatives

- Always consumes expensive (block) storage
- Additional vendor required for commercial support
Expand All @@ -41,13 +41,13 @@ The second question is to ensure that the data scientists don't need to directly

### Leverage Noobaa (Multi cloud gateway) to provide a flexible interface

*Positives*
#### Positives

- Flexible choice between using in cluster and out of cluster storage
- Multi-cluster setups can obfuscate origin of s3 across multiple sites
- Clear support path for downstream development

*Negatives*
#### Negatives

- Flexibility provides choice but also increases required parameters, documentation and instrumentation

Expand Down

0 comments on commit 546e816

Please sign in to comment.