Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SCCs from DSPv2 manifests #414

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Remove SCCs from DSPv2 manifests #414

merged 1 commit into from
Oct 20, 2023

Conversation

DharmitD
Copy link
Member

The issue resolved by this Pull Request:

Resolves #374

Description of your changes:

Testing instructions

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-414

@gmfrasca
Copy link
Member

@DharmitD or @rimolive - can you list in this PR description exactly what changed that made these SCCs no longer necessary?

@gmfrasca
Copy link
Member

@DharmitD or @rimolive - can you list in this PR description exactly what changed that made these SCCs no longer necessary?

Some context i found: kubeflow/pipelines#7916

Copy link
Contributor

@rimolive rimolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit ec35ad3 into opendatahub-io:dspv2 Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants