Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 await init_app_state #207

Merged
merged 1 commit into from
Jan 14, 2025
Merged

🐛 await init_app_state #207

merged 1 commit into from
Jan 14, 2025

Conversation

joerunde
Copy link
Contributor

Description

I broke this recently by making a change to vllm's init that will ensure the engine loads all provided lora modules at startup. This broke init_app_state because it needed to be async to wait on the engine.

This backwards-compatible change will check if init_app_state needs to be awaited, and awaits it.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Joe Runde <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.04%. Comparing base (384b732) to head (d215efa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   62.98%   63.04%   +0.06%     
==========================================
  Files          28       28              
  Lines        1748     1751       +3     
  Branches      216      217       +1     
==========================================
+ Hits         1101     1104       +3     
  Misses        541      541              
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tjohnson31415 tjohnson31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joerunde joerunde added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 8d297ae Jan 14, 2025
3 checks passed
@joerunde joerunde deleted the async-init branch January 14, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants