add pending PRs from ibm vllm #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantgupta24
changed the title
prashantgupta24
force-pushed
the
ibm-vllm-changes
branch
3 times, most recently
from
b169710 to
779710f
Compare
dtrifiro
reviewed
Jun 18, 2024
dtrifiro
reviewed
Jun 18, 2024
dtrifiro
reviewed
Jun 18, 2024
dtrifiro
reviewed
Jun 18, 2024
dtrifiro
reviewed
Jun 18, 2024
dtrifiro
reviewed
Jun 18, 2024
dtrifiro
reviewed
Jun 18, 2024
dtrifiro
reviewed
Jun 18, 2024
dtrifiro
reviewed
Jun 18, 2024
|
Thanks @prashantgupta24! The changes from my commits look good to me |
dtrifiro
force-pushed
the
ibm-vllm-changes
branch
from
d5aa66f to
5cf2cb0
Compare
prashantgupta24
commented
Jun 18, 2024
| from vllm.model_executor.guided_decoding import outlines_decoding | ||
| from vllm.model_executor.guided_decoding.outlines_decoding import ( | ||
| GuidedDecodingMode, | ||
| _get_cached_logits_processor, |
|
Looks good, would you mind rebasing to squash some of the commits together? |
Signed-off-by: Prashant Gupta <[email protected]>
enum ResponseFormat {
// Plain text, no constraints
TEXT = 0;
// Valid json
JSON = 1;
}
message StringChoices {
repeated string choices = 1;
}
// Mutually-exclusive guided decoding options
oneof guided {
// Output will be in the specified format
ResponseFormat format = 3;
// Output will follow the provided JSON schema
string json_schema = 4;
// Output will follow the provided regex pattern
string regex = 5;
// Output will be exactly one of the specified choices
StringChoices choice = 6;
// Output will follow the provided context free grammar
string grammar = 7;
}
Signed-off-by: Nick Hill <[email protected]>
Adds in this one more metric from TGIS --------- Signed-off-by: Joe Runde <[email protected]>
--------- Signed-off-by: Joe Runde <[email protected]>
Also don't set/return seed or other (random) sampling params when in greedy mode. Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Prashant Gupta <[email protected]>
Co-authored-by: Daniele <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Co-authored-by: Daniele <[email protected]>
prashantgupta24
force-pushed
the
ibm-vllm-changes
branch
from
c329d7f to
f2f1756
Compare
dtrifiro
force-pushed
the
concurrent-http-and-grpc
branch
from
52f4793 to
f861021
Compare
dtrifiro
force-pushed
the
concurrent-http-and-grpc
branch
4 times, most recently
from
7dec913 to
d1479e8
Compare
|
Merged in #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending PRs from https://github.com/IBM/vllm targeting
grpc_server.py