Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract inference results list in UNIPipe.pipe_analyze #1380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MatthewZMD
Copy link

Motivation

The UNIPipe.pipe_analyze method was directly using InferenceResult objects as model lists, which caused errors in pipe_parse since it expects an iterable list of inference results. This PR fixes these errors by properly extracting the underlying list data from InferenceResult objects.

Modification

Modified UNIPipe.pipe_analyze to call get_infer_res() on the doc_analyze results before assigning them to model_list. This ensures that model_list contains the actual list of inference results rather than InferenceResult objects, which allows pipe_parse to properly iterate over and process the results.

BC-breaking (Optional)

No BC-breaking changes. This modification fixes a bug in the internal implementation without changing any public APIs or interfaces. Downstream projects will continue to work as expected.

Use cases (Optional)

This is a bug fix that resolves errors when processing PDFs through the UNIPipe pipeline. It does not introduce new features.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Note: Tests should be added to verify:

  1. pipe_analyze properly extracts inference results for both TXT and OCR modes
  2. pipe_parse successfully processes the extracted results
  3. The full pipeline works correctly with the modified data flow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant