Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): improve list detection algorithm & fix(list): improve list identification accuracy #843

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

myhloli
Copy link
Collaborator

@myhloli myhloli commented Nov 2, 2024

Motivation

  • Add center_close_num and external_sides_not_close_num variables to analyze line positioning
  • Implement new list detection condition for centered lines
  • Enhance existing list detection logic with additional checks
  • Adjust the threshold for determining right-side spacing to 0.26 * block_weight
  • Add TODO comment for special list identification with all centered lines- Modify the condition for recognizing short item lists with left alignment
  • Update the condition for identifying the end of a list item

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

… for determining right-side spacing to 0.26 * block_weight

- Add TODO comment for special list identification with all centered lines- Modify the condition for recognizing short item lists with left alignment
- Update the condition for identifying the end of a list item
…d external_sides_not_close_num variables to analyze line positioning

- Implement new list detection condition for centered lines
- Enhance existing list detection logic with additional checks
@myhloli myhloli merged commit 1514cf8 into opendatalab:dev Nov 2, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant