-
Notifications
You must be signed in to change notification settings - Fork 36
Upgrade from 1.9.0 to 1.10.0 #215
Upgrade from 1.9.0 to 1.10.0 #215
Conversation
1. Upgraded ES-OSS from 7.8 to 7.9 2. Fixed compilation errors due to changes in 7.9 3. Added dependencies explicitly since after upgrading to 7.9, we saw error in powemockito. 4. Exclude asm transitive dependency, since those jar is already added by es in 7.9 explicitly 5. Remove jacoco.core, jacoco.report since it is part of ant.
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=========================================
Coverage 72.40% 72.40%
Complexity 1289 1289
=========================================
Files 139 139
Lines 6073 6073
Branches 469 469
=========================================
Hits 4397 4397
Misses 1464 1464
Partials 212 212
Flags with carried forward coverage won't be shown. Click here to find out more. |
compile "org.jacoco:org.jacoco.core:0.8.5" | ||
compile "org.jacoco:org.jacoco.report:0.8.5" | ||
compile ("org.jacoco:org.jacoco.ant:0.8.5") { | ||
exclude group: 'org.ow2.asm', module: 'asm-commons' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just asking, why exclude these modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ES 7.9, they added those dependencies ( https://github.com/elastic/elasticsearch/blob/master/modules/lang-painless/build.gradle#L36 ). We are also including this dependency through transitive from code-coverage . This caused jar Hell error ( es checks whether any multiple jars of same or different version is being included ). Hence, i excluded this jar to be added into our plugin while downloading org.jacoco:org.jacoco.ant for code coverage.
Launched ESS-OSS + Job-scheduler +AD |
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.