This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Upgrade mapping #278
Merged
Upgrade mapping #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
============================================
- Coverage 70.72% 70.08% -0.65%
- Complexity 1797 1815 +18
============================================
Files 187 190 +3
Lines 8687 8867 +180
Branches 735 756 +21
============================================
+ Hits 6144 6214 +70
- Misses 2194 2298 +104
- Partials 349 355 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ylwu-amzn
reviewed
Oct 19, 2020
| @@ -124,6 +126,7 @@ protected RestChannelConsumer prepareRequest(RestRequest request, NodeClient cli | |||
| ? WriteRequest.RefreshPolicy.parse(request.param(REFRESH)) | |||
| : WriteRequest.RefreshPolicy.IMMEDIATE; | |||
| RestRequest.Method method = request.getHttpRequest().method(); | |||
| anomalyDetectionIndices.updateMappingIfNecessary(); | |||
There was a problem hiding this comment.
Will this fail with FGAC ?
There was a problem hiding this comment.
Yeah..lets move this to transport layer. Since Anomaly Detection indices will be part of system index, we cannot update them.
There was a problem hiding this comment.
yeah, moved to transport layer. After moving, tested working with fgac.
This PR updates the current AD index mapping if a new version is detected. Previously, we didn't do so. This will cause issues when upgrading AD binary version: newly added fields will not be searchable, though we can still send get requests to fetch them. Testing done: 1. manual upgrade testing passes. 2. will add unit tests later.
kaituo
force-pushed
the
max_cache_handling
branch
from
c501a64 to
c599d37
Compare
ylwu-amzn
approved these changes
Oct 20, 2020
yizheliu-amazon
approved these changes
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR updates the current AD index mapping if a new version is detected. Previously, we didn't do so. This will cause issues when upgrading AD binary version: newly added fields will not be searchable, though we can still send get requests to fetch them.
This PR also makes the cache miss handling setting a dynamic setting.
Testing done:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.