-
Notifications
You must be signed in to change notification settings - Fork 31
Add Notebooks as Report Source Option #349
Add Notebooks as Report Source Option #349
Conversation
…mzn/kibana-reports into notebooks-integration
Codecov Report
@@ Coverage Diff @@
## dev #349 +/- ##
============================================
- Coverage 64.12% 63.99% -0.14%
Complexity 291 291
============================================
Files 100 100
Lines 4081 4138 +57
Branches 623 636 +13
============================================
+ Hits 2617 2648 +31
- Misses 1304 1330 +26
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions
kibana-reports/public/components/report_definitions/report_settings/report_settings.tsx
Outdated
Show resolved
Hide resolved
kibana-reports/public/components/report_definitions/report_settings/report_settings.tsx
Show resolved
Hide resolved
Any update for this PR? We are cleaning PRs and issues now to migrate to OpenSearch. |
I will cherry pick the commits over the OpenSearch for a new PR and close this PR. Would've done yesterday but had to take time off. |
This PR has been moved to opensearch-project |
Issue #, if available:
N/A
Description of changes:
Adds Kibana notebooks as a report source option in the Reporting plugin page. Visual reports can now be created for a Notebook just like a dashboard or visualization.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.