Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Add Notebooks as Report Source Option #349

Conversation

davidcui1225
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:
Adds Kibana notebooks as a report source option in the Reporting plugin page. Visual reports can now be created for a Notebook just like a dashboard or visualization.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #349 (b68580e) into dev (2c16ac9) will decrease coverage by 0.13%.
The diff coverage is 58.06%.

❗ Current head b68580e differs from pull request most recent head 2a1f5f6. Consider uploading reports for the commit 2a1f5f6 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #349      +/-   ##
============================================
- Coverage     64.12%   63.99%   -0.14%     
  Complexity      291      291              
============================================
  Files           100      100              
  Lines          4081     4138      +57     
  Branches        623      636      +13     
============================================
+ Hits           2617     2648      +31     
- Misses         1304     1330      +26     
  Partials        160      160              
Flag Coverage Δ Complexity Δ
Kibana-reports 76.61% <58.06%> (-0.69%) 0.00 <0.00> (ø)
reports-scheduler 53.28% <ø> (ø) 291.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ions/report_settings/report_settings_constants.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
kibana-reports/server/model/backendModel.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
kibana-reports/server/model/index.ts 77.77% <ø> (ø) 0.00 <0.00> (ø)
kibana-reports/server/routes/utils/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
...r/routes/utils/visual_report/visualReportHelper.ts 81.57% <0.00%> (-3.36%) 0.00 <0.00> (ø)
...csearch/reportsscheduler/model/ReportDefinition.kt 76.11% <ø> (ø) 7.00 <0.00> (ø)
...rt_definitions/report_settings/report_settings.tsx 84.80% <48.38%> (-4.53%) 0.00 <0.00> (ø)
kibana-reports/server/utils/validationHelper.ts 81.25% <58.33%> (-8.75%) 0.00 <0.00> (ø)
...itions/report_settings/report_settings_helpers.tsx 97.46% <87.50%> (-2.54%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c16ac9...2a1f5f6. Read the comment docs.

Copy link
Contributor

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions

@zhongnansu
Copy link
Member

Any update for this PR? We are cleaning PRs and issues now to migrate to OpenSearch.

@davidcui1225
Copy link
Contributor Author

Any update for this PR? We are cleaning PRs and issues now to migrate to OpenSearch.

I will cherry pick the commits over the OpenSearch for a new PR and close this PR. Would've done yesterday but had to take time off.

@davidcui1225
Copy link
Contributor Author

This PR has been moved to opensearch-project

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants