fix(status): update CSPI status when corresponding cStor pool-manager terminated #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… terminated This PR updates the CSPI status to **OFFLINE** whenever cStor pool-manager container is terminated. **NOTE**: Status will be not updated incase of forcibly shutdown of pods/nodes. Signed-off-by: mittachaitu <[email protected]>
akhilerm
reviewed
Jul 29, 2020
akhilerm
reviewed
Jul 29, 2020
akhilerm
reviewed
Jul 29, 2020
akhilerm
reviewed
Jul 29, 2020
Signed-off-by: mittachaitu <[email protected]>
mittachaitu
commented
Aug 3, 2020
…efore even creating the pool Signed-off-by: mittachaitu <[email protected]>
mittachaitu
commented
Aug 3, 2020
| // zpool commands will error out and fall into this scenario | ||
| c.recorder.Event(cspi, corev1.EventTypeWarning, | ||
| string(common.FailedSynced), | ||
| fmt.Sprintf("Unable to import a pool may be due to underlying pool disk might be lost or bad disk might be attached to the node"), |
There was a problem hiding this comment.
@sonasingh46 is there any better suggestion on event message?
There was a problem hiding this comment.
Failed to import the pool as the underlying pool might be lost or the disk has gone bad
sonasingh46
approved these changes
Aug 5, 2020
Signed-off-by: mittachaitu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CSPI status to OFFLINE whenever
cStor pool-manager container is terminated. Pod deletion, eviction,
scale down are a few scenarios that will cause the container
to terminate.
NOTE: Status will be not updated in case of aburupt
the shutdown of pods/nodes.
This PR fixes: #128
Signed-off-by: mittachaitu [email protected]