Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Original PVC context to the deployment labels. #151

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

farcaller
Copy link
Contributor

Pull Request template

Why is this PR required? What issue does it fix?:

This allows targeting the nfs workload pod using stable labels in e.g. CiliumNetworkPolicy rules. Currently the only label on the workload is openebs.io/nfs-server with the generated pvc name which cannot be deduced statically from the original pvc name.

What this PR does?:

Adds the name/namespace/id labels to the pod.

Does this PR require any upgrade changes?:

No.

If the changes in this PR are manually verified, list down the scenarios covered::

Using the pod in the CiliumNetworkPolicy, by targeting the new labels.

Any additional information for your reviewer? :

N/A

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Does this PR change require updating NFS-Provisioner Chart? If yes, mention the Helm Chart PR #
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@t3hmrman
Copy link

@abhilashshetty04
@niladrih
@pawanpraka1

Sorry to bother ya'll, -- this is a really useful feature, is it possible to merge & release it?

@abhilashshetty04
Copy link
Contributor

@avishnu

@niladrih
Copy link
Member

Thank you for the PR @farcaller. And thanks for the bump @t3hmrman. The CI checks seem to have not run, I'm putting the do-not-merge label on this one for a while.

Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what went wrong with the CI here, manual runs seem to pass. Accepted!

@niladrih niladrih merged commit fec0e57 into openebs-archive:develop Feb 9, 2023
@farcaller farcaller deleted the patch-1 branch February 9, 2023 17:05
niladrih added a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Niladri Halder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants