fix(cleanup,mempool): Cleanup mempool related thread while destroying a volume #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mayank <[email protected]>
Signed-off-by: mayank <[email protected]>
vishnuitta
reviewed
Jan 10, 2020
| ASSERT0(get_num_entries_from_mempool(&spec->rcommon_deadlist)); | ||
| destroy_rcommon_deadlist(spec); | ||
|
|
||
| pthread_cancel(spec->deadlist_cleanup_thread); |
There was a problem hiding this comment.
should we set cancel_type as asynchronous? it seems - default is deferred and it needs cancellation point
There was a problem hiding this comment.
can be canceled at any time (usually immediately, but the system does not guarantee this). Deferred cancelability means that cancellation will be delayed until the thread next calls a func‐
tion that is a cancellation point. A list of functions that are or may be cancellation points is provided in pthreads(7).
added 2 commits
January 10, 2020 20:38
Signed-off-by: mayank <[email protected]>
Signed-off-by: mayank <[email protected]>
vishnuitta
pushed a commit
to vishnuitta/istgt
that referenced
this pull request
Jan 10, 2020
… a volume (openebs-archive#301) Signed-off-by: mayank <[email protected]>
This was referenced Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mayank [email protected]