Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daemon): make config file path configurable #357

Merged
merged 3 commits into from
Dec 27, 2019

Conversation

akhilerm
Copy link
Contributor

The config file path was hardcoded to /host/node-disk-manager.config. This is now made configurable and can be provided via --config. This will help to run the NDM daemon as a standalone binary without needing to be in a container. When in the container the config file will be provided via a ConfigMap.

add config file as argument instead of doing with the default hardcoded filepath

Signed-off-by: Akhil Mohan <[email protected]>
@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #357 into master will increase coverage by 0.45%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   51.51%   51.97%   +0.45%     
==========================================
  Files          55       55              
  Lines        2634     2867     +233     
==========================================
+ Hits         1357     1490     +133     
- Misses       1170     1266      +96     
- Partials      107      111       +4
Impacted Files Coverage Δ
cmd/ndm_daemonset/controller/controller.go 19.49% <0%> (+2.02%) ⬆️
cmd/ndm_daemonset/controller/ndmconfig.go 75% <100%> (ø) ⬆️
cmd/ndm_daemonset/probe/eventhandler.go 46.05% <0%> (-7.9%) ⬇️
pkg/controller/disk/disk_controller.go 24.32% <0%> (-0.68%) ⬇️
cmd/ndm_daemonset/controller/blockdevicestore.go 86.18% <0%> (+2.48%) ⬆️
cmd/ndm_daemonset/probe/udevprobe.go 68.26% <0%> (+2.61%) ⬆️
cmd/ndm_daemonset/controller/diskstore.go 90.64% <0%> (+2.64%) ⬆️
pkg/udev/common.go 92.1% <0%> (+2.87%) ⬆️
...er/blockdeviceclaim/blockdeviceclaim_controller.go 44.09% <0%> (+5.62%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec102f7...d80acc8. Read the comment docs.

@akhilerm akhilerm requested a review from kmova December 18, 2019 10:45
@kmova kmova merged commit 768321e into openebs-archive:master Dec 27, 2019
@akhilerm akhilerm deleted the add-config-flag branch December 30, 2019 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants