Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build): Migrating from dep to Go modules #434

Merged
merged 3 commits into from
Jun 7, 2020

Conversation

RealHarshThakur
Copy link
Contributor

@RealHarshThakur RealHarshThakur commented Jun 5, 2020

Why is this PR required? What issue does it fix?:
Go modules is a better dependency management than dep.

What this PR does?:
Migrates to use Go modules

Does this PR require any upgrade changes?:

  • go version is upgraded to 1.14
  • Goinkgo and Gomega packages were upgraded

If the changes in this PR are manually verified, list down the scenarios covered::
Works on go 1.13 and 1.14

Steps performed :

  • go mod init
  • go mod tidy
  • Upgraded gomega and goinkgo to latest version to fix fsnotify error
  • Added go mod tidy and god mod verify in the Makefile
  • Removed gopkg.toml and gopkg.lock
  • Run integration test with sudo in .travis.yml
  • go mod vendor

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Signed-off-by: Harsh Thakur <[email protected]>
Signed-off-by: Harsh Thakur <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   43.63%   43.63%           
=======================================
  Files          61       61           
  Lines        2947     2947           
=======================================
  Hits         1286     1286           
  Misses       1559     1559           
  Partials      102      102           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c92bc6...0751266. Read the comment docs.

@akhilerm akhilerm requested review from akhilerm, kmova and mynktl June 5, 2020 19:02
.travis.yml Outdated Show resolved Hide resolved
@RealHarshThakur RealHarshThakur changed the title Migrating to Go modules refactor(build): Migrating from dep to Go modules Jun 6, 2020
Signed-off-by: Harsh Thakur <[email protected]>
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good.

please update the docs in a follow up PR.

@kmova kmova merged commit 7a73f6b into openebs-archive:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants