-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dependency): Upgrade go version to 1.14 #459
Conversation
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 44.74% 44.74%
=======================================
Files 64 64
Lines 2990 2990
=======================================
Hits 1338 1338
Misses 1548 1548
Partials 104 104 Continue to review full report at Codecov.
|
354eff0
to
03ed7da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: have some questions on the modules.txt
@harshthakur9030 Can you also add a changelog for this version upgrade? |
03ed7da
to
8d42802
Compare
Signed-off-by: Harsh Thakur <[email protected]>
8d42802
to
52ff463
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Pull Request template
Why is this PR required? What issue does it fix?:
This PR upgrades to go version to 1.14
What this PR does?:
It makes the CI and the repo's go version consistent with each other.
Does this PR require any upgrade changes?:
Yes, go version is upgraded
If the changes in this PR are manually verified, list down the scenarios covered::
Manually built the binary locally
Any additional information for your reviewer? :
Should be merged after removing gox PR as the go.mod file doesn't contain gox as a dependency anymore.
#456
Checklist:
<type>(<scope>): <subject>