Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependency): Upgrade go version to 1.14 #459

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

RealHarshThakur
Copy link
Contributor

Pull Request template

Why is this PR required? What issue does it fix?:
This PR upgrades to go version to 1.14

What this PR does?:
It makes the CI and the repo's go version consistent with each other.

Does this PR require any upgrade changes?:
Yes, go version is upgraded

If the changes in this PR are manually verified, list down the scenarios covered::
Manually built the binary locally

Any additional information for your reviewer? :
Should be merged after removing gox PR as the go.mod file doesn't contain gox as a dependency anymore.
#456

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020

Codecov Report

Merging #459 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   44.74%   44.74%           
=======================================
  Files          64       64           
  Lines        2990     2990           
=======================================
  Hits         1338     1338           
  Misses       1548     1548           
  Partials      104      104           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f964fc0...52ff463. Read the comment docs.

@RealHarshThakur RealHarshThakur force-pushed the bumpgo14 branch 2 times, most recently from 354eff0 to 03ed7da Compare July 14, 2020 05:14
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: have some questions on the modules.txt

@akhilerm
Copy link
Contributor

@harshthakur9030 Can you also add a changelog for this version upgrade?

Signed-off-by: Harsh Thakur <[email protected]>
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmova kmova merged commit 77e797e into openebs-archive:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants