fix(manager): disable metrics server from controller runtime #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latest controller runtime started a metrics server at port 8080 by default. This caused NDM to crash on systems where the port was already in use. Signed-off-by: Akhil Mohan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
=======================================
Coverage 40.53% 40.53%
=======================================
Files 71 71
Lines 3488 3488
=======================================
Hits 1414 1414
Misses 1966 1966
Partials 108 108
Continue to review full report at Codecov.
|
kmova
approved these changes
Aug 10, 2020
This was referenced Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan [email protected]
Why is this PR required? What issue does it fix?:
NDM was crashing on systems were port 8080 is already in use. NDM daemonset uses the host network and if the port 8080 on host machine is being used, NDM crashed. This was because controller-runtime by default tries to start a server at port 8080 as part of initialization, and if it fails, the initialization errors out.
What this PR does?:
Disables the default metrics server in daemonset and operator.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Run the NDM daemonset on a machine were port 8080 was already in use and no crashes were observed.
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>