chore(build) Updating dockerfile(s) with buildx built-in ARGs #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Fornaro <[email protected]> update release changelog Signed-off-by: Michael Fornaro <[email protected]>
xunholy
force-pushed
the
feature/dockerfile
branch
from
085ab53 to
9d1537b
Compare
akhilerm
reviewed
Oct 18, 2020
kmova
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Fornaro [email protected]
Updating Dockerfiles to use the
buildxbuilt-in ARGs will provide more flexibility to provide support for additional OS/ARCHS/ARM variants in the future. This also will create a cleaner and more maintainable Dockerfile moving forward.https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope
Checklist:
<type>(<scope>): <subject>