fix(status) update cstor volume status to offline based on availability of target pods #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mittachaitu
reviewed
Oct 11, 2021
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
added 2 commits
October 11, 2021 22:55
…ty of target pods Signed-off-by: Rupank Pahuja <[email protected]> Signed-off-by: Rupank Pahuja <[email protected]>
Signed-off-by: Rupank Pahuja <[email protected]> Signed-off-by: Rupank Pahuja <[email protected]>
saltperfect
force-pushed
the
377-updateCstoreVolumeStatus
branch
from
0aaba71 to
0a25441
Compare
Signed-off-by: Rupank Pahuja <[email protected]>
mittachaitu
reviewed
Oct 11, 2021
mittachaitu
reviewed
Oct 12, 2021
| _, err = c.clientset.CstorV1().CStorVolumes(cv.Namespace).Update(context.TODO(), &cv, metav1.UpdateOptions{}) | ||
| if err != nil { | ||
| klog.Errorf("failed to update CV: %s status to %s", cv.Name, apis.CVStatusOffline) | ||
| continue |
There was a problem hiding this comment.
Here also, we found the CV that required to update and processing other CV's will not helpful so we can return
Suggested change
| continue | |
| return |
Signed-off-by: Rupank Pahuja <[email protected]>
Signed-off-by: Rupank Pahuja <[email protected]>
mittachaitu
reviewed
Oct 26, 2021
added 7 commits
October 26, 2021 22:14
…ty of target pods Signed-off-by: Rupank Pahuja <[email protected]> Signed-off-by: Rupank Pahuja <[email protected]>
Signed-off-by: Rupank Pahuja <[email protected]> Signed-off-by: Rupank Pahuja <[email protected]>
Signed-off-by: Rupank Pahuja <[email protected]>
Signed-off-by: Rupank Pahuja <[email protected]>
Signed-off-by: Rupank Pahuja <[email protected]>
Signed-off-by: Rupank Pahuja <[email protected]>
Signed-off-by: Rupank Pahuja <[email protected]>
saltperfect
force-pushed
the
377-updateCstoreVolumeStatus
branch
from
dadc3ab to
72dfae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #377
I have tried to understand the project structure using documentation.
Also I have referred to these two PR as suggested by @mittachaitu
I am yet to add testcases. This is an initial commit to get reviews and check if I have done the changes in correct file. 😸 Once I have nailed down which files, I can go ahead and improve on other aspects of the PR.
First time contributor