feat(block): adding raw block volume support for LVM #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawan <[email protected]>
pawanpraka1
added
the
kind/feature
akhilerm
reviewed
Jan 27, 2021
pkg/driver/agent.go
Outdated
| @@ -115,7 +115,8 @@ func (ns *node) NodePublishVolume( | |||
| // If the access type is block, do nothing for stage | |||
There was a problem hiding this comment.
Didnt get this comment. This is the publish request.
There was a problem hiding this comment.
this is not a vaild comment here, this is for nodestagevolume grpc call.
There was a problem hiding this comment.
@pawanpraka1 Can you remove this comment,
akhilerm
reviewed
Jan 27, 2021
| volume := vol.Spec.VolGroup + "/" + vol.Name | ||
| devicePath := DevPath + volume | ||
|
|
||
| mountopt := []string{"bind"} |
There was a problem hiding this comment.
Why do we need to bind mount the device at a path during nodepublish. Is it a requirement from CSI?
There was a problem hiding this comment.
yes, we need to moount the device to the path where kubelet wants us to.
akhilerm
reviewed
Jan 27, 2021
Signed-off-by: Pawan <[email protected]>
akhilerm
approved these changes
Jan 28, 2021
Signed-off-by: Pawan <[email protected]>
kmova
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawan [email protected]
Why is this PR required? What issue does it fix?:
adding raw block volume support for LVM
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
tested with the sample fio yaml added in this PR