Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2e-tests): Add e2e-test for lvm-localpv #24

Merged
merged 1 commit into from
Mar 3, 2021
Merged

feat(e2e-tests): Add e2e-test for lvm-localpv #24

merged 1 commit into from
Mar 3, 2021

Conversation

w3aman
Copy link
Contributor

@w3aman w3aman commented Feb 22, 2021 •
edited
Loading

Signed-off-by: Aman Gupta [email protected]

What this PR does?

  • This PR adds e2e-test framework for lvm-localpv based e2e-test cases.

@codecov-io
Copy link

codecov-io commented Feb 22, 2021 •
edited
Loading

Codecov Report

Merging #24 (1aa7a7a) into master (8d7c97a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #24   +/-   ##
======================================
  Coverage    1.20%   1.20%           
======================================
  Files          11      11           
  Lines         831     830    -1     
======================================
  Hits           10      10           
+ Misses        821     820    -1
Impacted Files Coverage Δ
pkg/driver/controller.go 0.78% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7c97a...dbcac0f. Read the comment docs.

@pawanpraka1 pawanpraka1 added this to the v0.3 milestone Feb 22, 2021
@pawanpraka1 pawanpraka1 added the kind/feature Categorizes issue or PR as related to a new feature label Feb 22, 2021
@w3aman w3aman marked this pull request as ready for review February 23, 2021 14:27
@w3aman
Copy link
Contributor Author

w3aman commented Feb 25, 2021

cc: @gprasath @nsathyaseelan for review

nsathyaseelan
nsathyaseelan approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@nsathyaseelan nsathyaseelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pawanpraka1
pawanpraka1 approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@pawanpraka1 pawanpraka1 merged commit 755f4c3 into openebs:master Mar 3, 2021
@w3aman w3aman deleted the e2e branch April 16, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanpraka1 pawanpraka1 pawanpraka1 approved these changes

@nsathyaseelan nsathyaseelan nsathyaseelan approved these changes

@gprasath gprasath gprasath approved these changes

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@w3aman @codecov-io @pawanpraka1 @nsathyaseelan @gprasath