This repository has been archived by the owner on May 1, 2024. It is now read-only.
Add a numeric prefix to filenames to allow non alphabetical ordering of organizations #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhw
reviewed
Apr 22, 2019
exporter/properties.py
Outdated
| org_config = get_config_for_org(config, organization) | ||
|
|
||
| bucket = org_config['output_bucket'] | ||
| organization = organization.lower() | ||
|
|
||
| if any(fnmatch(organization, org) for org in orgs): | ||
| filename = os.path.join(directory, organization) | ||
| prefix = "{counter:05d}_".format(counter=org_counter) | ||
| filename = os.path.join(directory, prefix, organization) |
There was a problem hiding this comment.
I think this will create prefix as a separate subdirectory, no? You could include the organization in with the prefix format statement.....
There was a problem hiding this comment.
Fudge. Treated it as a concat, not really what I wanted. Will fix.
brianhw
reviewed
Apr 22, 2019
| @@ -59,15 +59,16 @@ def export_properties(config, directory, files=None, orgs=None, prefix=''): | |||
|
|
|||
| files_data = load_files(files) | |||
|
|
|||
| for organization in config['organizations']: | |||
| for org_counter, organization in enumerate(config['organizations']): | |||
There was a problem hiding this comment.
Here's a way to deal with a priority on a few entries:
orgconfig = config['organizations']
def check_priority(org):
if 'priority' in orgconfig[org]:
return org.upper()
else:
return org.lower()
for org_counter, organization in enumerate(sorted(orgconfig, key = check_priority)):
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.