fix: use .txt files inside .in files to ensure consistency across environments #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zawan-ila
force-pushed
the
anawaz/prod-3793
branch
3 times, most recently
from
04c4142 to
0ab0fb1
Compare
DawoudSheraz
reviewed
Feb 3, 2025
| @@ -0,0 +1,1029 @@ | |||
| # | |||
There was a problem hiding this comment.
If test.txt did not exist before, is it being used anywhere in CI flow? or is everything under local.txt?
There was a problem hiding this comment.
I don't think it's being used anywhere. If it were, things would have broken
There was a problem hiding this comment.
Should we not update test/CI to use test.txt? I mean the purpose of having the separate dependencies was to be able to use environment-specific dependencies.
There was a problem hiding this comment.
Updated the tests to use test.txt
AfaqShuaib09
approved these changes
Feb 4, 2025
zawan-ila
force-pushed
the
anawaz/prod-3793
branch
from
d573bf8 to
7a777fb
Compare
DawoudSheraz
approved these changes
Feb 6, 2025
zawan-ila
force-pushed
the
anawaz/prod-3793
branch
from
5a9a0ff to
8058d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-3793
If we include
.infiles as requirements (instead of.txtfiles), there is a possibility that different envs (dev, prod, local, test etc.) may get different versions of the same package. An example is the attrs package in our repository. The local env has version 21.4.0 whereas the prod env has version 25.1.0This PR is an attempt to ensure that package versions are consistent across environments.
It might be helpful to review the commits separately.