refactor: REST API to return a different response if LR MFE is enabled #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxFrank13
force-pushed
the
mfrank/LR-MFE-public-link
branch
from
5174eaa to
b539e61
Compare
justinhynes
reviewed
Sep 7, 2022
justinhynes
reviewed
Sep 7, 2022
justinhynes
reviewed
Sep 7, 2022
MaxFrank13
force-pushed
the
mfrank/LR-MFE-public-link
branch
from
b539e61 to
4f3efc4
Compare
justinhynes
reviewed
Sep 7, 2022
| response = self.client.post(rev, data=jdata, content_type=JSON_CONTENT_TYPE) | ||
| json_data = response.json() | ||
| self.assertEqual(response.status_code, 201) | ||
| self.assertRegex(json_data["url"], UUID_PATTERN) |
There was a problem hiding this comment.
One last suggestion. Can we improve the verification of this unit test? Instead of checking if the UUID is contained within the string, can we verify that the entire string is being built as we expected?
Since we are are now building a link to an external system... this would be a stronger test if we verified that the link is exactly as we expect it to be.
There was a problem hiding this comment.
Sounds like another job for a format string!
justinhynes
approved these changes
Sep 7, 2022
MaxFrank13
force-pushed
the
mfrank/LR-MFE-public-link
branch
from
4f3efc4 to
530055a
Compare
MaxFrank13
force-pushed
the
mfrank/LR-MFE-public-link
branch
from
530055a to
f84d7b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a REST API endpoint that creates a
ProgramCertRecordand returns the URL for that public record. Currently, that URL is routing to the legacy frontend. With this refactor, if the Learner Record MFE is enabled, it will instead return the URL for the MFE.