fix: added Makefile target to run tests with Karma #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinhynes
requested changes
Dec 7, 2022
Makefile
Outdated
| @@ -119,6 +119,10 @@ tests: ## Run tests and generate coverage report | |||
| js-tests: ## Run javascript tests | |||
| npm run test-react | |||
|
|
|||
| test-karma: ## Run JS tests through Karma & install firefox. This command needs to be ran manually in the devstack container before submitting a pull request. It can not be run in CI as of APER-2136. | |||
| sudo apt-get install --no-install-recommends -y firefox | |||
There was a problem hiding this comment.
Just in case, I would also add a line before this to update the package information for all the configured sources.
So, before the sudo apt-get install... line, add sudo apt-get update
There was a problem hiding this comment.
I think in the original CI workflow we were also installing xvfb. Maybe we should also include that package to cover our bases?
There was a problem hiding this comment.
Good call! The command now installs xvfb and then uses xvfb-run similar to how it's done here
MaxFrank13
force-pushed
the
mfrank/karma_tests_make_target
branch
from
9da5faf to
c9b0479
Compare
justinhynes
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new Makefile target that will install Firefox and run the tests using Karma. There is also a PR template that will remind future contributors to run these tests locally. Once a fix is found for getting these tests to run in CI, we will need to remove this PR template.