Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mfrank/pin sphinx #1888

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Mfrank/pin sphinx #1888

merged 1 commit into from
Jan 5, 2023

Conversation

MaxFrank13
Copy link
Member

Run JavaScript tests locally with Karma

There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.

  • Make sure you are inside the devstack container
  • Run make test-karma
  • All tests pass

justinhynes
justinhynes approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaxFrank13 MaxFrank13 merged commit e5dcc7f into master Jan 5, 2023
@MaxFrank13 MaxFrank13 deleted the mfrank/pin-sphinx branch January 5, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinhynes justinhynes justinhynes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxFrank13 @justinhynes