Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin mysqlclient version #2053

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix: pin mysqlclient version #2053

merged 1 commit into from
Jun 23, 2023

Conversation

MaxFrank13
Copy link
Member

Pinning version of mysqlclient to v2.1.1. See APER-2556 for more details and plan for follow up.

Run JavaScript tests locally with Karma

There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.

  • Make sure you are inside the devstack container
  • Run make test-karma
  • All tests pass

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the constraint!

@MaxFrank13 MaxFrank13 merged commit 851b3bb into master Jun 23, 2023
@MaxFrank13 MaxFrank13 deleted the mfrank/pinning-mysqlclient branch June 23, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants